add test_incorrect_xml_syntax

sphinxcontrib/datatemplates/directive.py

@@ -208,7 +208,7 @@ def run(self):
                 nodes.literal_block(self.block_text, self.block_text),
                 line=self.lineno)
             return [error]
-        except json.decoder.JSONDecodeError as err:
+        except (json.decoder.JSONDecodeError, ET.ParseError) as err:
             error = self.state_machine.reporter.error(
                 f"Error in source file '{relative_resolved_path}': {err}",
                 nodes.literal_block(self.block_text, self.block_text),

tests/test_errors.py

@@ -91,3 +91,14 @@ def test_incorrect_yaml_syntax(app: SphinxTestApp, warning: StringIO):
         '  in "sample.yaml", line 12, column 3'
     )
     assert expected_error_str in warning.getvalue()
+
+
+@pytest.mark.sphinx("html", testroot="incorrect-xml-syntax")
+def test_incorrect_xml_syntax(app: SphinxTestApp, warning: StringIO):
+    app.builder.build_all()
+    expected_error_str = (
+        f"{app.srcdir / 'index.rst'}:1: "
+        "ERROR: Error in source file 'sample.xml': "
+        "not well-formed (invalid token): line 2, column 4"
+    )
+    assert expected_error_str in warning.getvalue()

tests/testdata/test-incorrect-xml-syntax/conf.py

@@ -0,0 +1,2 @@
+extensions = ["sphinxcontrib.datatemplates"]
+templates_path = ["templates"]

tests/testdata/test-incorrect-xml-syntax/index.rst

@@ -0,0 +1,2 @@
+.. datatemplate:xml:: sample.xml
+    :template: sample.tmpl

tests/testdata/test-incorrect-xml-syntax/sample.xml

@@ -0,0 +1,20 @@
+<sample
+    <key1>value1</key1>
+    <key2>
+        <item>list item 1</item>
+        <item>list item 2</item>
+        <item special='yes'>list item 3</item>
+    </key2>
+    <mappingseries>
+        <mapping>
+            <cola special='yes'>a</cola>
+            <colb>b</colb>
+            <colc>c</colc>
+        </mapping>
+        <mapping>
+            <cola>A</cola>
+            <colb special='yes'>B</colb>
+            <colc>C</colc>
+        </mapping>
+    </mappingseries>
+</sample>

tests/testdata/test-incorrect-xml-syntax/templates/sample.tmpl

@@ -0,0 +1 @@
+{{data.find('key1').text}}