Behavior changes in test suite generator and executor modules #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloborba
approved these changes
Jun 27, 2024
leusonmario
reviewed
Jun 28, 2024
| self._java.exec_javac(java_file, test_suite_path, None, None, | ||
| '-classpath', class_path, '-d', compiled_classes_path) | ||
| except: | ||
| pass |
There was a problem hiding this comment.
Considerando que conhecemos a exceção que ocorre, poderíamos levantá-la, e continuar com a execução do for. O que acha?
There was a problem hiding this comment.
Acrescentei uma mensagem no log
leusonmario
requested changes
Jul 2, 2024
| pass | ||
| except CalledProcessError: | ||
| logging.error(f"Error while compiling {java_file}") | ||
| continue |
There was a problem hiding this comment.
Eu apenas removeria o continue, considerando que a exceção é capturada e tratada, o for continua naturalmente com a sua próxima interação.
ToniMaciel
approved these changes
Jul 2, 2024
leusonmario
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correções Implementadas:
Arquivo:
nimrod/test_suites_execution/test_suite_executor.pytest_classnão era encontrada, a execução resultava em um erro que era interpretado como um teste falho. Porém, como o nome do teste não era encontrado, o resultado do teste era marcado como PASS, mesmo sem o teste existir de fato.ifque mantémresultscomo vazio caso a situação ocorra novamente.Arquivo:
nimrod/test_suite_generation/generators/test_suite_generator.pyjava_file) no diretório falhasse na compilação, todo o processo de compilação era interrompido.try-exceptpara que, em caso de falha na compilação de umjava_file, ele seja ignorado e o processo de compilação continue com os próximos arquivos.