Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert string slice to string using strings.Join(s, ","). #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eiffel-fl
Copy link

Hi!

In this PR, I added support to convert string slice to string using strings.Join(s, ",").
I was experimenting yesterday with some code based on spf13/viper and was surprised to get an empty string as result of calling GetString() on a config key I know was a string slice.
Moreover, I did not get any error message, as GetString() did not return one:
https://github.com/spf13/viper/blob/551e8939be1e18c45accb6d144e6c19e46ee24e1/viper.go#L785-L787

As I think this code may be useful for other people, I decided to open a PR.
Please let me know what you think about it.

Best regards.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants