DUI3-325 Add Civil3d 2024 connector #3531
Conversation
| @@ -64,6 +64,7 @@ public static class HostApplications | |||
| Unity = new("Unity", "unity"), | |||
| GSA = new("GSA", "gsa"), | |||
| Civil = new("Civil 3D", "civil3d"), | |||
There was a problem hiding this comment.
do we need this one if we added Civil3D?
There was a problem hiding this comment.
Yes, to prevent breaking the DUI2 connectors
There was a problem hiding this comment.
I believe we should start to consider have new Applications(?) class for DUI3 only instead populating old.
There was a problem hiding this comment.
FYI: @BovineOx added as subtask under the other relevant story (assigned to Ian) https://spockle.atlassian.net/browse/DUI3-431
Core/Core/Kits/Applications.cs
Outdated
| @@ -124,6 +125,11 @@ public static HostApplication GetHostAppFromString(string? appname) | |||
| return Civil; | |||
| } | |||
|
|
|||
| if (appname.Contains("civil3d")) | |||
There was a problem hiding this comment.
what is the difference with "civil"? because this will always return the previous one I believe because it will contain already "civil"
There was a problem hiding this comment.
Ah good point, will fix this
| @@ -1,3 +1,4 @@ | |||
| #if AUTOCAD | |||
There was a problem hiding this comment.
It might make sense to put note here why we do this
There was a problem hiding this comment.
We can have shared module for autocad verticals, seems we are having many dups
| // Register bindings | ||
| builder.AddSingleton<IBinding, TestBinding>(); | ||
| builder.AddSingleton<IBinding, AccountBinding>(); | ||
| builder.AddSingleton<IBinding, AutocadBasicConnectorBinding>(); |
There was a problem hiding this comment.
I believe this is unnecessary registration since we register it on next line as IBasicConnectorBinding
There was a problem hiding this comment.
This was preexisting, so I'm leaving it here for now
Description & motivation
Adds the Civil3d 2024 connector, with just a send binding, to the Autocad connector folder. Also adds a corresponding Autocad2024 converter so that civil3d connector can send out of the box.
Changes:
Civil3dConnectorModulein the connector to allow for Civil3d bindings to differ from Autocad, and preprocessor directives inAutocadCommandto create anAutocadSettingswith the correct host app and versionScreenshots:
Sent a point from Civil3d: https://app.speckle.systems/projects/b53a53697a/models/719612f9da