Blocks POC (Rhino, Acad)

Core/Core/Models/Instances/IInstanceComponent.cs

@@ -0,0 +1,12 @@
+namespace Speckle.Core.Models.Instances;
+
+/// <summary>
+/// Abstracts over <see cref="InstanceProxy"/> and <see cref="InstanceDefinitionProxy"/> for sorting and grouping in receive operations.
+/// </summary>
+public interface IInstanceComponent
+{
+  /// <summary>
+  /// The maximum "depth" at which this <see cref="InstanceProxy"/> or <see cref="InstanceDefinitionProxy"/> was found. It's important to get right: as instances can be composed of other instances, we need to start from the deepest instance elements first when reconstructing them, starting with definitions first.
+  /// </summary>
+  public int MaxDepth { get; set; }
+}

Core/Core/Models/Instances/InstanceDefinitionProxy.cs

@@ -0,0 +1,19 @@
+using System.Collections.Generic;
+
+namespace Speckle.Core.Models.Instances;
+
+/// <summary>
+/// A proxy class for an instance definition.
+/// </summary>
+public class InstanceDefinitionProxy : Base, IInstanceComponent
+{
+  /// <summary>
+  /// The original ids of the objects that are part of this definition, as present in the source host app. On receive, they will be mapped to corresponding newly created definition ids.
+  /// </summary>
+  public List<string> Objects { get; set; } // source app application ids for the objects
+
+  /// <summary>
+  /// The maximum "depth" at which this instance was found. It's important to get right: as instances can be composed of other instances, we need to start from the deepest instance elements first when reconstructing them.
+  /// </summary>
+  public int MaxDepth { get; set; }
+}

Core/Core/Models/Instances/InstanceProxy.cs

@@ -0,0 +1,29 @@
+using System.DoubleNumerics;
+
+namespace Speckle.Core.Models.Instances;
+
+/// <summary>
+/// A proxy class for an instance (e.g, a rhino block, or an autocad block reference).
+/// </summary>
+public class InstanceProxy : Base, IInstanceComponent
+{
+  /// <summary>
+  /// The definition id as present in the original host app. On receive, it will be mapped to the newly created definition id.
+  /// </summary>
+  public string DefinitionId { get; set; }
+
+  /// <summary>
+  /// The transform of the instance reference.
+  /// </summary>
+  public Matrix4x4 Transform { get; set; }
+
+  /// <summary>
+  /// The units of the host application file.
+  /// </summary>
+  public string Units { get; set; } = Kits.Units.Meters;
+
+  /// <summary>
+  /// The maximum "depth" at which this instance was found. It's important to get right: as instances can be composed of other instances, we need to start from the deepest instance elements first when reconstructing them.
+  /// </summary>
+  public int MaxDepth { get; set; }
+}

DUI3-DX/Connectors/Autocad/Speckle.Connectors.AutocadShared/Bindings/AutocadBasicConnectorBinding.cs

@@ -8,6 +8,7 @@
 using Speckle.Core.Credentials;
 using Speckle.Connectors.Autocad.HostApp.Extensions;
 using Speckle.Connectors.Utils;
+using Speckle.Core.Logging;
 
 namespace Speckle.Connectors.Autocad.Bindings;
 
@@ -108,34 +109,48 @@ public void HighlightModel(string modelCardId)
       return;
     }
 
-    HighlightObjectsOnView(objectIds);
+    HighlightObjectsOnView(objectIds, modelCardId);
   }
 
-  private void HighlightObjectsOnView(ObjectId[] objectIds)
+  private void HighlightObjectsOnView(ObjectId[] objectIds, string? modelCardId = null)
   {
     var doc = Application.DocumentManager.MdiActiveDocument;
 
     Parent.RunOnMainThread(() =>
     {
-      doc.Editor.SetImpliedSelection(Array.Empty<ObjectId>()); // Deselects
-      doc.Editor.SetImpliedSelection(objectIds); // Selects
-      doc.Editor.UpdateScreen();
+      try
+      {
+        doc.Editor.SetImpliedSelection(Array.Empty<ObjectId>()); // Deselects
+        doc.Editor.SetImpliedSelection(objectIds); // Selects
+        doc.Editor.UpdateScreen();
+
+        Extents3d selectedExtents = new();
 
-      Extents3d selectedExtents = new();
+        var tr = doc.TransactionManager.StartTransaction();
+        foreach (ObjectId objectId in objectIds)
+        {
+          var entity = (Entity)tr.GetObject(objectId, OpenMode.ForRead);
+          if (entity != null)
+          {
+            selectedExtents.AddExtents(entity.GeometricExtents);
+          }
+        }
 
-      var tr = doc.TransactionManager.StartTransaction();
-      foreach (ObjectId objectId in objectIds)
+        doc.Editor.Zoom(selectedExtents);
+        tr.Commit();
+        Autodesk.AutoCAD.Internal.Utils.FlushGraphics();
+      }
+      catch (Exception ex) when (!ex.IsFatal())
       {
-        var entity = (Entity)tr.GetObject(objectId, OpenMode.ForRead);
-        if (entity != null)
+        if (modelCardId != null)
+        {
+          Commands.SetModelError(modelCardId, new OperationCanceledException("Failed to highlight objects."));
+        }
+        else
         {
-          selectedExtents.AddExtents(entity.GeometricExtents);
+          //???
         }
       }
-
-      doc.Editor.Zoom(selectedExtents);
-      tr.Commit();
-      Autodesk.AutoCAD.Internal.Utils.FlushGraphics();
     });
   }
 }

DUI3-DX/Connectors/Autocad/Speckle.Connectors.AutocadShared/DependencyInjection/AutocadConnectorModule.cs

@@ -1,3 +1,4 @@
+using Autodesk.AutoCAD.DatabaseServices;
 using Speckle.Autofac;
 using Speckle.Autofac.DependencyInjection;
 using Speckle.Connectors.Autocad.Bindings;
@@ -15,6 +16,7 @@
 using Speckle.Connectors.Utils;
 using Speckle.Connectors.Utils.Builders;
 using Speckle.Connectors.Utils.Caching;
+using Speckle.Connectors.Utils.Instances;
 using Speckle.Connectors.Utils.Operations;
 using Speckle.Core.Models.GraphTraversal;
 
@@ -62,5 +64,6 @@ public void Load(SpeckleContainerBuilder builder)
 
     // register send conversion cache
     builder.AddSingleton<ISendConversionCache, SendConversionCache>();
+    builder.AddScoped<IInstanceObjectsManager<AutocadRootObject, List<Entity>>, AutocadInstanceObjectManager>();
   }
 }