-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUI3-293] logging poc bindings and bridge #3515
Merged
JR-Morgan
merged 22 commits into
dui3/alpha
from
DUI3-293-logging-poc-bindings-and-bridge
Jun 21, 2024
Merged
[DUI3-293] logging poc bindings and bridge #3515
JR-Morgan
merged 22 commits into
dui3/alpha
from
DUI3-293-logging-poc-bindings-and-bridge
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
changed the title
[Dui3-293] logging poc bindings and bridge
[DUI3-293] logging poc bindings and bridge
Jun 17, 2024
…g-poc-bindings-and-bridge
…c-bindings-and-bridge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary questions and comments. I liked it overall as we walk through before ❤️
DUI3-DX/Connectors/Rhino/Speckle.Connectors.Rhino7/Bindings/RhinoSelectionBinding.cs
Outdated
Show resolved
Hide resolved
DUI3-DX/DUI3/Speckle.Connectors.DUI/Bridge/TopLevelExceptionHandler.cs
Outdated
Show resolved
Hide resolved
adamhathcock
approved these changes
Jun 20, 2024
adamhathcock
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important changes
TopLevelExceptionHandler
service.OnDocumentChange
) and is used in the Bridge for Bindings.TODO:
Test some of the async Action Block changes in CEF 65 (Revit 2021)<- not easy, agreed with Dim that we can do this laterFigure out the best practice for logging (https://spockle.atlassian.net/browse/DUI3-389ILogger<T>
orILoggerFactory
)Ask Ian about circular depsUnwrap target invocation of sync binding calls (atleast for the execute method return)<- I've done it slightly differently, I'm re-wrapping with a better messageDo one last test in all connectors, injecting some exceptions in a few places...Double check logs appear in sync with structured paramsCheck that we aren't somehow changing threads for the async overloads of the toplevel catch<- impossible for no async stuff, we don't do any async