Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable lock files for dui3 #3510

Merged
merged 9 commits into from
Jun 20, 2024
Merged

enable lock files for dui3 #3510

merged 9 commits into from
Jun 20, 2024

Conversation

adamhathcock
Copy link
Member

enable nuget lock files for dui3

  • this will allow us to better monitor change in dependencies
  • use lock files for restoration for repeatable builds
  • cache nuget and restore for faster builds

@adamhathcock adamhathcock enabled auto-merge (squash) June 14, 2024 12:21
AlanRynne
AlanRynne requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also modify the CI to run in locked mode since we're at it

AlanRynne
AlanRynne reviewed Jun 20, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated
deploy-installers:
runs-on: ubuntu-latest
runs-on: windows-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be windows at all 🙂

@adamhathcock adamhathcock merged commit cc81dc2 into dui3/alpha Jun 20, 2024
3 checks passed
@adamhathcock adamhathcock deleted the lock-files-dui3 branch June 20, 2024 09:00
@adamhathcock
Copy link
Member Author

For https://spockle.atlassian.net/browse/DUI3-311

@adamhathcock
Copy link
Member Author

DUI3-311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamhathcock @AlanRynne