DUI3-173: adds send and receive cancellation on document switch #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,7 +92,7 @@ private void OnSendOperationProgress(string modelCardId, string status, double? | |||
| // POC: JEDD: We should not update the UI until a OperationCancelledException is caught, we don't want to show the UI as cancelled | |||
| // until the actual operation is cancelled (thrown exception). | |||
| // I think there's room for us to introduce a cancellation pattern for bindings to do this and avoid this _cancellationManager | |||
| public void CancelSend(string modelCardId) => _cancellationManager.CancelOperation(modelCardId); | |||
There was a problem hiding this comment.
Was it really that much wrong all this time? 🤦♂️
| public async Task Receive(string modelCardId) | ||
| { | ||
| using var unitOfWork = _unitOfWorkFactory.Resolve<ReceiveOperation>(); | ||
| try | ||
| { | ||
| Application.DocumentManager.DocumentActivated += (sender, args) => |
There was a problem hiding this comment.
Not sure way of subscribing it, let's hold it till tomorrow AM and sync?
…ation-when-send-receive-is-in-progress
AlanRynne
approved these changes
Jun 20, 2024
clairekuang
deleted the
DUI3-173-RVT-ACAD-Fix-new-document-creation-when-send-receive-is-in-progress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Prevents document activation (creation/switch) during ongoing send/receive operation.