Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcgis - default geospatial database location to Speckle folder #332

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

KatKatKateryna
Copy link
Contributor

@KatKatKateryna KatKatKateryna commented Oct 28, 2024

If Project location is not writeable, save the .gdb file to the Speckle folder

@KatKatKateryna
Copy link
Contributor Author

@AlanRynne here is the PR for defaulting it to Temp folder, once Speckle path is public I will replace

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.39%. Comparing base (5783b83) to head (89b3123).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #332   +/-   ##
=====================================
  Coverage   8.39%   8.39%           
=====================================
  Files        240     240           
  Lines       4835    4835           
  Branches     562     562           
=====================================
  Hits         406     406           
  Misses      4412    4412           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatKatKateryna KatKatKateryna marked this pull request as ready for review October 28, 2024 22:40
@KatKatKateryna KatKatKateryna changed the title Arcgis - default database location to Temp or Speckle folder Arcgis - default geospatial database location to Speckle folder Oct 28, 2024
@KatKatKateryna
Copy link
Contributor Author

not sure if failing test is related to updated nugets

@AlanRynne
Copy link
Member

Missing the lock file changes after changing a nuget version.

dotnet restore and commit the lock files should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants