Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(revit): view filter #322

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

Conversation

oguzhankoral
Copy link
Member

chrome_gUJwkxj2b4

Copy link

linear bot commented Oct 23, 2024

CNX-544 View Filter

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.39%. Comparing base (5783b83) to head (05098bc).

Files with missing lines Patch % Lines
...odels/Card/SendFilter/DirectSelectionSendFilter.cs 0.00% 1 Missing ⚠️
...DUI/Models/Card/SendFilter/EverythingSendFilter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #322      +/-   ##
========================================
- Coverage   8.39%   8.39%   -0.01%     
========================================
  Files        240     240              
  Lines       4835    4837       +2     
  Branches     562     562              
========================================
  Hits         406     406              
- Misses      4412    4414       +2     
  Partials      17      17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairekuang clairekuang self-requested a review October 24, 2024 12:53
Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try a different version of this by prompting users to select the views from the project browser, and treating the UX/UI the same as the selection filter.

Main reasoning behind this is so we don't need new UI components for View filters, and we don't need to worry about keeping the DUI synced with the hostApp state when users add/delete views while in the view filter view.

Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try a different version of this by prompting users to select the views from the project browser, and treating the UX/UI the same as the selection filter.

Main reasoning behind this is so we don't need new UI components for View filters, and we don't need to worry about keeping the DUI synced with the hostApp state when users add/delete views while in the view filter view.

@clairekuang
Copy link
Member

Only comment on this is that iterating with GetElement() through all ChangedObjIds just to test for a changed view seems kinda expensive. Might want to compare with using the filtered element collector for doc views, esp on large models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants