-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(revit): view filter #322
base: dev
Are you sure you want to change the base?
Conversation
oguzhankoral
commented
Oct 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #322 +/- ##
========================================
- Coverage 8.39% 8.39% -0.01%
========================================
Files 240 240
Lines 4835 4837 +2
Branches 562 562
========================================
Hits 406 406
- Misses 4412 4414 +2
Partials 17 17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try a different version of this by prompting users to select the views from the project browser, and treating the UX/UI the same as the selection filter.
Main reasoning behind this is so we don't need new UI components for View filters, and we don't need to worry about keeping the DUI synced with the hostApp state when users add/delete views while in the view filter view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try a different version of this by prompting users to select the views from the project browser, and treating the UX/UI the same as the selection filter.
Main reasoning behind this is so we don't need new UI components for View filters, and we don't need to worry about keeping the DUI synced with the hostApp state when users add/delete views while in the view filter view.
1bc1bdf
to
4017d22
Compare
Only comment on this is that iterating with |