Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape class names of result types named after PHP reserved keywords #111

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

spawnia
Copy link
Owner

@spawnia spawnia commented Oct 7, 2024

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Resolves #110

Changes

Escape the names of result types that are named like PHP reserved keynames, e.g. a field that returns a type Case will result in a generated class name of _Case.

Breaking changes

No, this did not work at all before.

@spawnia spawnia merged commit 6a42958 into master Oct 7, 2024
26 checks passed
@spawnia spawnia deleted the escape-classname branch October 7, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When trying to make a query named "Cases" - exceptions are thrown because it's not escaped somewhere
1 participant