add crop

spatie · Sep 5, 2023 · e7b45e2 · e7b45e2
1 parent e0a2ed5
commit e7b45e2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/Drivers/Gd/GdImageDriver.php b/src/Drivers/Gd/GdImageDriver.php
@@ -149,18 +149,17 @@ protected function modify(
             imagesavealpha($modified, true);
         }
 
-        // copy content from resource
         imagecopyresampled(
             $modified,
             $this->image,
             0,
             0,
-            0,
-            0,
+            $sourceX,
+            $sourceY,
+            $desiredWidth,
+            $desiredHeight,
             $desiredWidth,
             $desiredHeight,
-            $originalWidth,
-            $originalHeight
         );
 
         $this->image = $modified;

diff --git a/tests/Manipulations/ManualCropTest.php b/tests/Manipulations/ManualCropTest.php
@@ -5,12 +5,11 @@
 use Spatie\Image\Image;
 
 it('can contain an image in the given dimensions', function (
+    ImageDriver $driver,
     array $dimensions,
     int $expectedWidth,
     int $expectedHeight,
 ) {
-    $driver = Image::useImageDriver('gd');
-
     $targetFile = $this->tempDir->path("{$driver->driverName()}/manual-crop.jpg");
 
     $driver->load(getTestJpg())->manualCrop(...$dimensions)->save($targetFile);
@@ -20,6 +19,6 @@
     $savedImage = $driver->load($targetFile);
     expect($savedImage->getWidth())->toBe($expectedWidth);
     expect($savedImage->getHeight())->toBe($expectedHeight);
-})->with([
-    [[1, 2,3,4], 0, 0],
+})->with('drivers')->with([
+    [[100, 50, 0, 50], 100, 50],
 ]);