Don't show numbers as spelling errors #34
Conversation
|
|
| stream.next(); | ||
| } | ||
|
|
||
| if(CodeMirrorSpellChecker.typo && !CodeMirrorSpellChecker.typo.check(word) && !~customWords.indexOf(word)) |
There was a problem hiding this comment.
Looks like you removed the one line that used customWords.
There was a problem hiding this comment.
Oops, indeed! Sorry about that. I put it back.
|
Thanks for making the change. One last thing—can you set up a JSFiddle to demonstrate this change? |
|
any updates on getting this merged and released? |
|
I couldn't figure out how to get a JSFiddle working... |
|
At long last, here is a working CodePen: https://codepen.io/edemaine/pen/QoooOa I had to update a few more things to get this working again:
Hopefully this can now be merged. @WesCossick if you'd rather hand off maintenance, I could try. |
|
Hey @WesCossick |
This is a fix for #32. I just check whether the word matches
/^[0-9]+$/and ignore it if so.Along the way, I cleaned up the tokenizer to use regular expressions to detect word characters. This has two advantages:
"very long string".includeswhich will check against each character individually. Regular expressions should (I think) build a map to check for matching characters. Also, regular expressions should allow us to read the entire word at once instead of character by character.