Skip to content

Commit

Permalink
Pin BoTorch to 0.4.0 (facebook#507)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#507

As discussed with Balandat offline yesterday, we should pin BoTorch versions so that we don't always have to release Ax right after BoTorch.

Right now, we're in a slightly dangerous state where BoTorch 0.4.0 is released, and so because our setup.py file runs `pip install botorch>=0.3.3`, pip will install 0.4.0 now. But the stable version of Ax is actually not compatible with this newest version of BoTorch (as you can see from the failure of this test: https://github.com/facebook/Ax/runs/1967381927?check_suite_focus=true).

Reviewed By: lena-kashtelyan

Differential Revision: D26635518

fbshipit-source-id: bd34718a9faf55f3dbc0bf6115a96b72f4468372
  • Loading branch information
ldworkin authored and facebook-github-bot committed Feb 24, 2021
1 parent 8b8b7e3 commit c428eb1
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
botorch: ['stable', 'minimum']
botorch: ['stable', 'pinned']
fail-fast: false

steps:
Expand All @@ -29,12 +29,12 @@ jobs:
# will automatically install latest stable Botorch
pip install -q -e .[dev,mysql,notebook]
if: matrix.botorch == 'stable'
- name: Install dependencies (minimum Botorch)
- name: Install dependencies (pinned Botorch)
run: |
# TODO: read minimum supported Botorch version from a shared source
pip install botorch==0.3.3
# TODO: read pinned Botorch version from a shared source
pip install botorch==0.4.0
pip install -q -e .[dev,mysql,notebook]
if: matrix.botorch == 'minimum'
if: matrix.botorch == 'pinned'
- name: Import Ax
run: |
python scripts/import_ax.py
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
botorch: ['stable', 'minimum']
botorch: ['stable', 'pinned']

steps:
- uses: actions/checkout@v2
Expand All @@ -26,12 +26,12 @@ jobs:
# will automatically install latest stable Botorch
pip install -q -e .[dev,mysql,notebook]
if: matrix.botorch == 'stable'
- name: Install dependencies (minimum Botorch)
- name: Install dependencies (pinned Botorch)
run: |
# TODO: read minimum supported Botorch version from a shared source
pip install botorch==0.3.3
# TODO: read pinned Botorch version from a shared source
pip install botorch==0.4.0
pip install -q -e .[dev,mysql,notebook]
if: matrix.botorch == 'minimum'
if: matrix.botorch == 'pinned'
- name: Import Ax
run: |
python scripts/import_ax.py
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

from setuptools import find_packages, setup


MIN_BOTORCH_VERSION = "0.3.3"
# TODO: read pinned Botorch version from a shared source
PINNED_BOTORCH_VERSION = "0.4.0"

REQUIRES = [
f"botorch>={MIN_BOTORCH_VERSION}",
f"botorch=={PINNED_BOTORCH_VERSION}",
"jinja2", # also a Plotly dep
"pandas",
"scipy",
Expand Down

0 comments on commit c428eb1

Please sign in to comment.