Skip to content

Commit

Permalink
Pin nbconvert and revert html parsing
Browse files Browse the repository at this point in the history
Summary: fix the nbconvert to old and revert the html parsing

Reviewed By: lena-kashtelyan

Differential Revision: D24051937

fbshipit-source-id: 7c540d3f9a22f2f8cedaeab69ac10e53289ee5be
  • Loading branch information
Steve Mandala authored and facebook-github-bot committed Oct 1, 2020
1 parent 16cb868 commit 4e97a0c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions scripts/make_tutorials.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,9 @@ def gen_tutorials(

# pull out html div for notebook
soup = BeautifulSoup(html, "html.parser")
nb_meat = soup.find("div", {"class": "jp-Notebook"})
nb_meat.attrs["class"].append(["notebook"])
nb_meat = soup.find("div", {"id": "notebook-container"})
del nb_meat.attrs["id"]
nb_meat.attrs["class"] = ["notebook"]

# when output html, iframe it (useful for Ax reports)
for html_div in nb_meat.findAll("div", {"class": "output_html"}):
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"sphinx<3.0.0",
"sphinx-autodoc-typehints",
"torchvision>=0.5.0",
"nbconvert<=5.6.1",
]

MYSQL_REQUIRES = ["SQLAlchemy>=1.1.13"]
Expand Down

0 comments on commit 4e97a0c

Please sign in to comment.