Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] use mini_portile mkmf_config(static:) to simplify extconf #2977

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Sep 13, 2023

What problem is this PR intended to solve?

Simplifying the extconf by using the new mkmf_config feature in mini_portile 2.8.5

Have you included adequate test coverage?

Existing test coverage is sufficient to ensure nothing's broken

Does this change affect the behavior of either the C or the Java implementations?

N/A

@flavorjones flavorjones changed the title [draft] use mini_portile 2.9.0.rc1 to simplify extconf [draft] use mini_portile 2.8.5.rc1 to simplify extconf Sep 13, 2023
@flavorjones
Copy link
Member Author

Welp, the BSD build is actually a legit failure -- looks like it's dynamically linking the system shared libxml2 library rather than statically linking the packaged libxml2 library. Need to investigate what's going on there.

@flavorjones
Copy link
Member Author

Update: I've reproduced the FreeBSD failure using system ruby on freebsd 13.2, but it doesn't reproduce if I use a ruby installed via rbenv/ruby-build.

@flavorjones
Copy link
Member Author

OK, reproduced with a system ruby on an Ubuntu image: https://github.com/sparklemotion/nokogiri/actions/runs/6209371364/job/16856521387?pr=2977

@flavorjones flavorjones changed the title [draft] use mini_portile 2.8.5.rc1 to simplify extconf [draft] use mini_portile 2.8.5.rc2 to simplify extconf Sep 19, 2023
@flavorjones flavorjones force-pushed the flavorjones-mini_portile-2.9 branch 2 times, most recently from 8c3672b to d15d1af Compare February 22, 2024 02:49
@flavorjones flavorjones changed the title [draft] use mini_portile 2.8.5.rc2 to simplify extconf [draft] use mini_portile mkmf_config(static:) to simplify extconf Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant