Migrate course and project related blocks #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yumincho
requested review from
sboh1214,
Davidace136,
useruseruse and
jooyeongmee
|
먼저 PR 올려주셔서 작업하는데 참고하고 있습니다! 혹시 custom translation hook 이 필요한 부분이 아닌 다른 부분에서 useTranslation hook 이 아니라 withTranslation HOC 을 사용한 이유가 있는지 궁금합니다! |
yumincho
commented
Mar 19, 2024
| ); | ||
| }; | ||
|
|
||
| export default withTranslation()(React.memo(CourseSimpleBlock)); |
There was a problem hiding this comment.
@useruseruse 이 부분을 말씀하신 거라면 원래부터 withTranslation()을 사용하고 있어서 변경하지 않았습니다. 다른 부분을 말씀하신 거라면 혹시 인용해서 좀 더 자세히 설명해주실 수 있나요?
sboh1214
reviewed
Mar 20, 2024
sboh1214
reviewed
Mar 20, 2024
sboh1214
reviewed
Mar 20, 2024
sboh1214
reviewed
Mar 20, 2024
| } | ||
|
|
||
| /** | ||
| * Component `CourseSimpleBlock` displays a brief overview of a course within the `CourseRelatedCoursesSubSection` on the `DictionaryPage`. |
There was a problem hiding this comment.
이거 한글로 적을지 영어로 적을지 팀 내에서 협의가 필요할 것 같아요
sboh1214
reviewed
Mar 20, 2024
sboh1214
reviewed
Mar 20, 2024
sboh1214
reviewed
Mar 20, 2024
sboh1214
force-pushed
the
migration@components/blocks3
branch
from
00fd48e
to
76ae674
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@/components/blocks중 4개 block을.tsx로 전환하면서 다음 작업을 진행했습니다.useTranslatedStringhook을 사용하는 것으로 변경했습니다.Checklist