Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complement shapes migration #48

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Complement shapes migration #48

merged 3 commits into from
Mar 14, 2024

Conversation

yumincho
Copy link
Contributor

@yumincho yumincho commented Mar 14, 2024 •
edited
Loading

Description

PR #44 의 해결되지 않은 코멘트 중 일부를 해결합니다.

Checklist

  • enum.ts 수정
  • Lecture interface 수정
  • new line 제거

Todo

  • paths @/* 적용에 대해 논의합니다.
  • 반복적인 interface들은 extend해 사용합니다.

@yumincho yumincho added the migrate migrate from JS CC to TS FC label Mar 14, 2024
@yumincho yumincho self-assigned this Mar 14, 2024
@yumincho yumincho requested a review from sboh1214 March 14, 2024 05:57
@yumincho yumincho marked this pull request as ready for review March 14, 2024 06:01
sboh1214
sboh1214 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dog LGTM

@sboh1214 sboh1214 merged commit 1bc2258 into migration Mar 14, 2024
3 checks passed
@sboh1214 sboh1214 deleted the migration@shapes branch March 14, 2024 07:25
@yumincho yumincho added this to the TypeScript Migration milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboh1214 sboh1214 sboh1214 approved these changes

Assignees

@yumincho yumincho

Labels
migrate migrate from JS CC to TS FC
Projects
None yet
Milestone
Refactoring & Migration
Development

Successfully merging this pull request may close these issues.
2 participants
@yumincho @sboh1214