Migrate LectureGroupBlock to typescript #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useruseruse
changed the title
useruseruse
changed the title
|
잘 수정하신 것 같습니다! 다만 타입을 만들 때 이름 convention은 어떻게 할지, 파일 위치는 어떻게 할지 등등에 대해서 팀 전체적인 논의를 하고 넘어가야 할 것 같아요. 이 부분은 한명이 일괄로 작업을 해야 나중에 conflict 없이 진행할 수 있을 것 같고요 |
|
그리고 혹시 Classtime과 Lecture에는 interface를 쓰고 Examtime과 NestedProfessor에는 type를 쓰셨는데 섞어서 쓰신 이유가 있을까요? |
|
헉 처음에 type로 작업하다가 이후에 interface로 다 바꿨는데 그 두개 파일 수정이 안된 것 같아요.. 딱히 이유는 없습니다..! |
| isTimetableReadonly: boolean; | ||
| inCart: boolean; | ||
| fromCart: boolean; | ||
| addToCart: (lecture: lectureType) => void; |
There was a problem hiding this comment.
반복되는 타입은 별도로 분리하는게 좋을 것 같습니다!
sboh1214
force-pushed
the
chore@migration-lectureGroupBlock
branch
from
025b350
to
34d77a5
Compare
sboh1214
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
아래 항목 tsx로 이전