Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #199, Fix iOS widget not working and add support tinted widget #200

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

s8ngyu
Copy link
Contributor

@s8ngyu s8ngyu commented Oct 2, 2024

Description

  • Backend migration 이후 iOS widget이 작동하지 않는 오류를 수정합니다.
    • sessionid -> token 로직 변경으로 인해 로그인이 진행되지 않았습니다.
    • api/semesters에서 넘겨주는 date string format이 변경되었습니다.
  • 코드 최적화를 진행하였습니다.
  • 하는김에 여러가지 신기능을 추가하였습니다.
    • iOS 17 부터 지원하는 containerBackground 지원을 추가하였습니다. (macOS, iPadOS 에서 .vibrant인 상황에서 정상적으로 표시됩니다.)
    • iOS 18 부터 지원하는 tinted customisation 지원을 추가하였습니다.
  • GitHub Actions Xcode 버전을 Xcode_16으로 올렸습니다.

Screenshots

@s8ngyu s8ngyu added bug Something isn't working feat New feature or request chore labels Oct 2, 2024
@s8ngyu s8ngyu self-assigned this Oct 2, 2024
@s8ngyu s8ngyu linked an issue Oct 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/l label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 31.04%. Comparing base (ecc690a) to head (bf3c831).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/main_page.dart 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   31.09%   31.04%   -0.06%     
==========================================
  Files          80       80              
  Lines        4850     4858       +8     
==========================================
  Hits         1508     1508              
- Misses       3342     3350       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특정 시간 이후부터는 모든 요일에 수업이 존재하지 않을때, 수업이 존재하는 시간까지만 시간표가 스크롤되면 좋을 것 같습니다. 수고하셨습니다.

Screenshot 1 Screenshot 2
IMG_4698 IMG_4697

@sboh1214 sboh1214 merged commit 44d3d9a into main Oct 27, 2024
6 of 8 checks passed
@sboh1214 sboh1214 deleted the fix@ios-widget branch October 27, 2024 14:27
Copy link

@sparcscasio sparcscasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sboh1214 sboh1214 removed the chore label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat New feature or request size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] iOS widgets not working after the backend migration
4 participants