Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Xcode 16, update GitHub Actions scripts #198

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Conversation

sboh1214
Copy link
Contributor

@sboh1214 sboh1214 commented Sep 14, 2024

변경사항

  • Fix iOS build issue on Xcode 16, macOS 15.1 Beta (24B5035e)
  • Bump iOS minimum version to 13.0 (due to firebase)
  • Update GitHub Actions deps versions
  • Update Android deps versions
  • Changed deprecated onPopInvoked to onPopInvokedWithResult

GitHub Actions 업데이트

  • FLUTTER_VERSION: 3.22.3 > 3.24.0
  • macos runner: 13 > 14
  • XCODE_VERSION: 15.0 > 16 RC
  • IOS_DEVICE: iPhone 14 Pro > 15 Pro
  • ANDROID_API_LEVEL: 28 > 34

참고자료

Firebase iOS 빌드 이슈

firebase/flutterfire#12962

image

GitHub Actions Android Emulator 설정

https://github.com/ReactiveCircus/android-emulator-runner?tab=readme-ov-file#running-hardware-accelerated-emulators-on-linux-runners

스크린샷 2024-09-14 오후 12 52 39

Flutter 버전 업그레이드

❯ flutter analyze
Analyzing otl-app...                                                    

   info • 'onPopInvoked' is deprecated and shouldn't be used. Use onPopInvokedWithResult instead. This feature was deprecated after v3.22.0-12.0.pre • lib/widgets/lecture_search.dart:30:7 • deprecated_member_use

1 issue found. (ran in 2.4s)

Android Build Script 오류

https://stackoverflow.com/questions/69033022/message-error-resource-androidattr-lstar-not-found

@sboh1214 sboh1214 added the chore label Sep 14, 2024
@sboh1214 sboh1214 self-assigned this Sep 14, 2024
FLUTTER_VERSION: 3.22.3 > 3.24.0
macos runner: 13 > 14-arm64
XCODE_VERSION: 15.0 > 16 Beta 6
IOS_DEVICE: iPhone 14 Pro > 15 Pro
ANDROID_API_LEVEL: 28 > 34
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.13%. Comparing base (7c9b56d) to head (3be62c6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lib/widgets/lecture_search.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   31.12%   31.13%           
=======================================
  Files          80       80           
  Lines        4854     4847    -7     
=======================================
- Hits         1511     1509    -2     
+ Misses       3343     3338    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/m and removed size/s labels Sep 14, 2024
@sboh1214 sboh1214 marked this pull request as ready for review September 14, 2024 08:12
@sboh1214 sboh1214 changed the title Fix build on xcode 16 Fix build on Xcode 16, update GitHub Actions scripts Sep 14, 2024
@sboh1214 sboh1214 merged commit 575f342 into main Sep 14, 2024
7 of 8 checks passed
@sboh1214 sboh1214 deleted the chore@xcode-16 branch September 14, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant