Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #192, show more info in timetable block #197

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

s8ngyu
Copy link
Contributor

@s8ngyu s8ngyu commented Sep 12, 2024

Description

Timetable block의 title label maxLine을 2로 조정하였습니다. location label fontSize를 줄였습니다.

Screenshot

CleanShot 2024-09-12 at 13 53 06@2x

@s8ngyu s8ngyu added the bug Something isn't working label Sep 12, 2024
@s8ngyu s8ngyu self-assigned this Sep 12, 2024
@s8ngyu s8ngyu linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.09%. Comparing base (b7b2b06) to head (369e44d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   31.10%   31.09%   -0.02%     
==========================================
  Files          80       80              
  Lines        4851     4850       -1     
==========================================
- Hits         1509     1508       -1     
  Misses       3342     3342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@happycastle114 happycastle114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@sboh1214 sboh1214 added feat New feature or request design and removed bug Something isn't working labels Sep 14, 2024
@sboh1214 sboh1214 changed the title Resolve #192, fix timetable block layout Resolve #192, show more info in timetable block Sep 14, 2024
@sboh1214 sboh1214 merged commit 6f3858a into main Sep 14, 2024
14 checks passed
@sboh1214 sboh1214 deleted the bug@timetable-block-label branch September 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design feat New feature or request size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Should show more lines in timetable block
3 participants