Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #96, #102, #109, 영어 번역 (시간표 제외), 전체 디자인 점검 (시간표 제외), 팝업 구현 #108

Merged
merged 11 commits into from
Jul 30, 2023

Conversation

hoosong0235
Copy link
Contributor

Frame 4
Frame 1
Frame 2
Frame 3

@hoosong0235 hoosong0235 added feat New feature or request design labels Jul 30, 2023
@hoosong0235 hoosong0235 self-assigned this Jul 30, 2023
@sboh1214 sboh1214 changed the title 영어 번역 (시간표 제외), 전체 디자인 점검 (시간표 제외), 팝업 구현 Resolve #96, #102, 영어 번역 (시간표 제외), 전체 디자인 점검 (시간표 제외), 팝업 구현 Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #108 (6699137) into main (c3ae3ed) will decrease coverage by 0.27%.
The diff coverage is 27.66%.

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   26.36%   26.09%   -0.27%     
==========================================
  Files          76       75       -1     
  Lines        4116     4346     +230     
==========================================
+ Hits         1085     1134      +49     
- Misses       3031     3212     +181     
Files Changed Coverage Δ
lib/extensions/course.dart 23.52% <0.00%> (-12.84%) ⬇️
lib/extensions/lecture.dart 0.00% <0.00%> (-38.47%) ⬇️
lib/home.dart 0.00% <0.00%> (ø)
lib/pages/dictionary_page.dart 0.00% <0.00%> (ø)
lib/pages/liked_review_page.dart 0.00% <0.00%> (ø)
lib/pages/main_page.dart 0.00% <0.00%> (ø)
lib/pages/my_review_page.dart 0.00% <0.00%> (ø)
lib/pages/review_page.dart 0.00% <0.00%> (ø)
lib/pages/timetable_page.dart 3.78% <0.00%> (+0.05%) ⬆️
lib/pages/user_page.dart 0.00% <0.00%> (ø)
... and 23 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoosong0235 hoosong0235 linked an issue Jul 30, 2023 that may be closed by this pull request
@hoosong0235 hoosong0235 changed the title Resolve #96, #102, 영어 번역 (시간표 제외), 전체 디자인 점검 (시간표 제외), 팝업 구현 Resolve #96, #102, #109, 영어 번역 (시간표 제외), 전체 디자인 점검 (시간표 제외), 팝업 구현 Jul 30, 2023
@sboh1214 sboh1214 merged commit 8536f30 into main Jul 30, 2023
6 of 8 checks passed
@sboh1214 sboh1214 deleted the feat@seungho branch July 30, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design feat New feature or request size/xl
Projects
None yet
3 participants