-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/bulletin search page separating consonants vowels #90
Merged
skykhs3
merged 7 commits into
dev
from
fix/bulletin-search-page-separating-consonants-vowels
Feb 18, 2024
Merged
Fix/bulletin search page separating consonants vowels #90
skykhs3
merged 7 commits into
dev
from
fix/bulletin-search-page-separating-consonants-vowels
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
skykhs3
commented
Feb 16, 2024
- 자음 모음 분리 현상 해결.
- 검색 전과 검색 결과 없을 때 UI 개선.
- 디바운스 기법으로 실시간 검색 최적화
기존: 검색창에 "나는"을 붙여넣기로 한 번에 넣어도, 한글은 중간 조합 문자이기 때문에 "ㄴ","나","난","나는" 이 모두 렌더링 되는 문제가 발생. 참조: https://www.flutterdecode.com/how-to-debounce-textfield-onchange-in-dart/
sangohkim
reviewed
Feb 18, 2024
sangohkim
reviewed
Feb 18, 2024
sangohkim
reviewed
Feb 18, 2024
sangohkim
requested changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료했습니다. 코드는 별다른 요구사항이 없고 주석 관련 코멘트 몇가지 달아놓았습니다.
sangohkim
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
skykhs3
deleted the
fix/bulletin-search-page-separating-consonants-vowels
branch
February 18, 2024 15:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.