Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bulletin search page separating consonants vowels #90

Merged
merged 7 commits into from
Feb 18, 2024

Conversation

skykhs3
Copy link
Collaborator

@skykhs3 skykhs3 commented Feb 16, 2024

  • 자음 모음 분리 현상 해결.
  • 검색 전과 검색 결과 없을 때 UI 개선.
  • 디바운스 기법으로 실시간 검색 최적화

@skykhs3 skykhs3 self-assigned this Feb 16, 2024
Copy link
Collaborator

@sangohkim sangohkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료했습니다. 코드는 별다른 요구사항이 없고 주석 관련 코멘트 몇가지 달아놓았습니다.

@skykhs3
Copy link
Collaborator Author

skykhs3 commented Feb 18, 2024

리뷰 반영했습니다.
Screenshot_20240219-000205
Screenshot_20240219-000217
Screenshot_20240219-000720

Copy link
Collaborator

@sangohkim sangohkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skykhs3 skykhs3 merged commit 5da6346 into dev Feb 18, 2024
2 checks passed
@skykhs3 skykhs3 deleted the fix/bulletin-search-page-separating-consonants-vowels branch February 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants