Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostListShowPage 전체 LoadingIndicator 일부 추가 #187

Merged
merged 1 commit into from
May 5, 2024

Conversation

sangohkim
Copy link
Collaborator

Overview

PostListShowPage의 전체 LoadingIndicator가 페이지를 처음 로드했을 때만 한정하여 보이도록 함

Changes

post_list_show_page.dart 파일 내부의 일부 코드 변경

  • RefreshIndicator() 내부 로직
  • build() 메서드 내부

Implementaion Method

After Changes

PostListShowPage를 에뮬레이터 또는 실물기기 환경에서 로드하여 확인가능.

Related Issues

#186

Rollback Scenario

build() 내부의 body에서 삼항연산자 제거.

TODO

없음.

@sangohkim sangohkim added the enhancement New feature or request label May 3, 2024
@sangohkim sangohkim added this to the v1.1.0 milestone May 3, 2024
@sangohkim sangohkim self-assigned this May 3, 2024
@sangohkim sangohkim changed the title Feat(post_list_show_page.dart): add initial loading indicator PostListShowPage 전체 LoadingIndicator 일부 추가 May 3, 2024
@sangohkim sangohkim linked an issue May 3, 2024 that may be closed by this pull request
@sangohkim sangohkim marked this pull request as ready for review May 3, 2024 12:00
Copy link
Contributor

@thomaskim1130 thomaskim1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaskim1130 thomaskim1130 merged commit f425d91 into dev May 5, 2024
2 checks passed
@thomaskim1130 thomaskim1130 deleted the feature/post-list-initial-loading branch May 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] PostListShowPage initial LoadingIndicator() 추가
2 participants