Add communication boards to MainPage #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placeholder code for communication section
sangohkim
changed the title
|
Deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
MainPage에 소통 관련 게시판 정보(학교에게 전합니다, 아라 피드백, 입주업체 피드백, 카이스트 뉴스)를 추가함 -> 사람들이 아라의 소통 관련 기능(특히 학교에게 전합니다)을 직관적으로 알 수 있는 효과 기대.
Changes
MainPage에서 캐싱하는 항목이 하나 증가.
Implementaion Method
기존 MainPage에서 사용하고 있던 로직에 소통 관련 항목만 새로 추가함.
After Changes
MainPage에서 직접 확인 가능.
Related Issues
#166
Rollback Scenario
_buildMessagesToSchoolContents(), _initMessagesToSchool(), _initKaistNews(), _initAraFeedback(), _initFacilityFeedback(), isLoading에서 소통 항목에 해당하는 인덱스 등등을 제거하면 됨.
TODO
현재 디자인이 과연 적절한지 논의해보아야 함.