Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): usertable horizontal scroll, agenda section gap, #370

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

donghyo1234
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit 8c21046
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/650aecdcb94b090008850a61
😎 Deploy Preview https://deploy-preview-370--biseo-preview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donghyo1234 donghyo1234 changed the title feat(ui): usertable horizontal scroll, agenda gap feat(ui): usertable sort, horizontal scroll, agenda section gap, Sep 13, 2023
@donghyo1234 donghyo1234 linked an issue Sep 13, 2023 that may be closed by this pull request
@donghyo1234 donghyo1234 changed the title feat(ui): usertable sort, horizontal scroll, agenda section gap, feat(ui): usertable horizontal scroll, agenda section gap, Sep 13, 2023
@donghyo1234
Copy link
Contributor Author

image
image
image
image

@donghyo1234
Copy link
Contributor Author

image

@babycroc
Copy link
Contributor

스크롤은 잘 되는데 행 길이가 찌뿌됐달까(?) 이렇게 보여요!
image

.husky/pre-commit Outdated Show resolved Hide resolved
client/src/components/atoms/Scroll.tsx Outdated Show resolved Hide resolved
@babycroc
Copy link
Contributor

@SnowSuno 요거 아직 안 고쳐졌는뎅
scroll x가 table body 말고 header도 같이 되게 하기
table row width 잘리는거
두 개의 이슈가 존재해요

@Ariaspect Ariaspect added the FE Tasks for the front-end part label Sep 19, 2023
@donghyo1234
Copy link
Contributor Author

donghyo1234 commented Sep 20, 2023

이제 유저들 row 길이 최대로 맞추는 것이랑, 헤더가 x 방향으로는 같이 스크롤 되고 y 방향으로는 안되는 것은 구현이 되었는데 헤더 row길이가 좌우로 가득 차지 않는 문제가 발생했습니다 ㅠ 어떻게 해결해야 할 지 전혀 모르겠습니다
image

@babycroc
Copy link
Contributor

@donghyo1234 그거 header 안에 태그 Cell width가 int라서 그럴지도 걔도 fill 이런걸로 해야할거같은데 확신은 없다

@babycroc
Copy link
Contributor

Header tag랑 그 안에 있는 Cell들 너비를 잘 건드리면 될거같아

@donghyo1234
Copy link
Contributor Author

되는 대로 다 건드려 봐도 잘 안 되긴 했지만 계속 작업 해보겠습니당

@babycroc
Copy link
Contributor

힝 그렇군 나도 함 건드려볼게 혹시 되면 카톡으로도 알려줭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Tasks for the front-end part
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UserTable] 유저테이블 태그 많으면 좌우 스크롤 AgendaCard에 gap이 적용되지 않음
3 participants