Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imviz simple aperture photometry plugin #930

Closed
wants to merge 3 commits into from
Closed

Imviz simple aperture photometry plugin #930

wants to merge 3 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 12, 2021 •
edited
Loading

Description

This pull request is to add a plugin to perform simple aperture photometry in Imviz.

Blocked by:

TODO:

  • Actually implement the plugin.
  • Add change log.
  • Polish up POC notebook for demo.
  • Write tests.
  • Update Imviz user-facing doc. Need Kyle's help with the tooltips stuff.
  • ???
  • Profit!

Pre-requisite for #531 .

🐱

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added this to the 2.1 milestone Oct 12, 2021
@github-actions github-actions bot added the documentation Explanation of code and concepts label Oct 12, 2021
@pllim pllim added imviz feature Feature request labels Oct 12, 2021
@pllim
WIP: POC notebook and plugin for aper phot.
fe08492 
Removed unused AddViewerMessage.

Added new RemoveViewerMessage and tied it to viewer destroy event.

photutils is now a required dependency.

[ci skip]
@pllim
WIP: Added doc, more plugin stuff [ci skip]
abb9b4b
@pllim pllim mentioned this pull request Oct 15, 2021
Merged
19 tasks
@pllim
Copy link
Contributor Author

pllim commented Oct 15, 2021

Superseded by #938.

@pllim pllim closed this Oct 15, 2021
@pllim pllim deleted the one-hour-photometry branch October 15, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh will be requested when the pull request is marked ready for review javerbukh is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry will be requested when the pull request is marked ready for review kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

Assignees
No one assigned
Labels
documentation Explanation of code and concepts feature Feature request imviz Upstream fix required
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
1 participant
@pllim