data-menu: handle viewer rename properly

[kecnry]

Description

This pull request fixes tracebacks caused by the new data-menu when renaming a viewer (currently only used by downstream lcviz - this fixes broken tests in spacetelescope/lcviz#158 when run locally).

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (19ddfac) to head (260af52).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
jdaviz/core/template_mixin.py	50.00%	4 Missing ⚠️
...viz/configs/default/plugins/data_menu/data_menu.py	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3383      +/-   ##
==========================================
- Coverage   88.02%   88.00%   -0.02%     
==========================================
  Files         127      127              
  Lines       19717    19730      +13     
==========================================
+ Hits        17356    17364       +8     
- Misses       2361     2366       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cshanahan1]

does this need to set viewer id as well like in data_menu?

[kecnry]

no, this only tracks the reference so doesn't need to worry about whether the id has changed or not