Address review comments

jdaviz/configs/cubeviz/plugins/viewers.py

@@ -222,6 +222,7 @@ def active_image_layer(self):
         return visible_layers[-1]
 
     def _on_global_display_unit_changed(self, msg):
+        # Clear cache of slice values when units change
         if 'slice_values' in self.__dict__:
             del self.__dict__['slice_values']
 
@@ -289,6 +290,7 @@ def _default_flux_viewer_reference_name(self):
         return self.jdaviz_helper._default_flux_viewer_reference_name
 
     def _on_global_display_unit_changed(self, msg=None):
+        # Clear cache of slice values when units change
         if 'slice_values' in self.__dict__:
             del self.__dict__['slice_values']
 

jdaviz/configs/specviz/plugins/unit_conversion/unit_conversion.vue

@@ -33,7 +33,7 @@
     </v-row>
     <v-row v-if="config === 'cubeviz'">
         <span class="v-messages v-messages__message text--secondary" style="color: red !important">
-          Flux conversion is not yet implemented in cubeviz
+          Flux conversion is not yet implemented in Cubeviz.
         </span>
     </v-row>
   </j-tray-plugin>

jdaviz/core/template_mixin.py

@@ -2872,8 +2872,8 @@ def _get_continuum(self, dataset, spatial_subset, spectral_subset, update_marks=
                           'center': spectral_axis.value,
                           'right': []}
             else:
-                mark_x = {'left': spectral_axis_nanmasked[spectral_axis < sr_lower],
-                          'right': spectral_axis_nanmasked[spectral_axis > sr_upper]}
+                mark_x = {'left': spectral_axis_nanmasked[spectral_axis < sr_lower].value,
+                          'right': spectral_axis_nanmasked[spectral_axis > sr_upper].value}
                 # Center should extend (at least) across the line region between the full
                 # range defined by the continuum subset(s).
                 # OK for mark_x to be all NaNs.