Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pens for heads #33034

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Pens for heads #33034

wants to merge 5 commits into from

Conversation

justdie12
Copy link
Contributor

@justdie12 justdie12 commented Oct 28, 2024

logo-ru

About the PR

Make some funny stuff for heads. I will make more, for clown or mime, but now i PR'd this.

Why / Balance

In emergency everybody needs a pen! (QM is a businessman, he urgently needs money)

Technical details

Media

https://drive.google.com/file/d/1HRsDyp97hmL2DK1-Wf5W7R5CRk4OWekn/view?usp=sharing

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added No C# For things that don't need code. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. labels Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

RSI Diff Bot; head commit 87c49d9 merging into 7e526da
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Misc/pens.rsi

State Old New Status
o1 Added
o2 Added
pen_CE Added
pen_CMO Added
pen_HOS_off Added
pen_HOS_on Added
pen_QM Added
pen_RD Added
pen_RD_ink-unshaded-0 Added
pen_RD_ink-unshaded-1 Added
pen_RD_ink-unshaded-2 Added
pen_RD_ink-unshaded-3 Added

Edit: diff updated after 87c49d9

@deltanedas
Copy link
Contributor

clown gets luxury crayon instead of pen

@beck-thompson
Copy link
Contributor

It would be nice if you wrote out the change along with the video!

@justdie12
Copy link
Contributor Author

It would be nice if you wrote out the change along with the video!

i do, but it's so big...
https://drive.google.com/file/d/1HRsDyp97hmL2DK1-Wf5W7R5CRk4OWekn/view?usp=sharing
there

@ps3moira
Copy link
Contributor

ps3moira commented Oct 28, 2024

what would be the point of unique pen's for every single head 🤔 do we really need 7+ different kinds of pens?

@KaiserMaus
Copy link

New Thief sleal objective?

@ArtisticRoomba
Copy link
Contributor

Pen thief objective would be a good excuse to have cool custom pens for each head.

I like it, but my only gripe is that the art style of the pens clashes with the current pens (HoP and Cap) in the game. They seem too thick.

@UbaserB
Copy link
Member

UbaserB commented Oct 28, 2024

this is kind of weird

@justdie12
Copy link
Contributor Author

Pen thief objective would be a good excuse to have cool custom pens for each head.

I like it, but my only gripe is that the art style of the pens clashes with the current pens (HoP and Cap) in the game. They seem too thick.

ooookay, i go to re-sprite

@pheenty
Copy link
Contributor

pheenty commented Oct 28, 2024

I'd remove self-recharging from everyone but CE

@justdie12
Copy link
Contributor Author

justdie12 commented Oct 28, 2024

I'd remove self-recharging from everyone but CE

they very slow self-recharges itself in cause of emergency. 10 minutes for self-recharging, kinda slow?

on the other hand, it is better to make them non-rechargeable from charging stations

@justdie12
Copy link
Contributor Author

Resprited and reviewed. Added some cool stuff like animation

Copy link
Contributor

@Plykiya Plykiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balance feedback

angle: 60
animation: WeaponArcSlash
- type: StaminaDamageOnHit
damage: 100
Copy link
Contributor

@Plykiya Plykiya Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For very obvious balance reasons this can't be in the game as a one or even two hit stun. It out classes stun batons, the HoS shotgun, disablers, rigged boxing gloves, any kind of meme bola combo, etc. and makes the HoS nearly unkillable solo. The pen basically outclasses their energy shotgun in usefulness.

Whether it should even deal stamina damage, maintainers will probably mention something about that...

@Plykiya
Copy link
Contributor

Plykiya commented Oct 28, 2024

It would be nice if you wrote out the change along with the video!

i do, but it's so big... https://drive.google.com/file/d/1HRsDyp97hmL2DK1-Wf5W7R5CRk4OWekn/view?usp=sharing there

a changelog for this kind of unassumingly large content PR is going to be necessary, especially when it affects game balance

@ArtisticRoomba
Copy link
Contributor

Wow I thought they were just regular pens... After looking at the diff, good lord.

@justdie12
Copy link
Contributor Author

balance feedback

image
image

@Aisu9
Copy link

Aisu9 commented Oct 28, 2024

balance feedback

image image

weren't taser removed from station spawn and T3 security research tho

@LankLTE
Copy link
Contributor

LankLTE commented Oct 28, 2024

I don’t personally think each head needs their own unique pen, but especially not ones that have side-effects that are this strong. From the looks of it the RD’s just completely invalidates the CHIMP research and the HoS’s is just a stronger baton. These are pens, they should be for writing.

@ps3moira
Copy link
Contributor

ps3moira commented Oct 28, 2024

I agree it's pretty unnecessary for individual pens for each head and comes off bloaty.

@justdie12
Copy link
Contributor Author

I don’t personally think each head needs their own unique pen, but especially not ones that have side-effects that are this strong. From the looks of it the RD’s just completely invalidates the CHIMP research and the HoS’s is just a stronger baton. These are pens, they should be for writing.

c.h.i.m.p. which recharges for 10 minutes devalues the game? Well, or a stanbaton that rolls back 66 minutes?

@ArtisticRoomba
Copy link
Contributor

Yeah after reading the diffs, it would be way better for these pens to not have abilities at all. I'm not going to reiterate what others have said, but it's just too much.

I'd prefer it if they simply got a better looking pen with no abilities.

@UBlueberry
Copy link
Contributor

UBlueberry commented Oct 28, 2024

this PR is slightly misleading, at face value it just seems like pen reskins but - surprise! - please find stun baton attached.

also the lore of this is kinda wild when you think about it. there's an entire blender in CMO's pen?!

@LittleNorthStar
Copy link
Contributor

If they're going to get unique abilities they need to be minor things which are already accomplished by other stuff
what I would do for example
CMO pen can be used for cauterizing injuries
RD pen can scan anomalies (make it take longer than a normal scanner if possible)
HOS pen can hold 5 units of a liquid (for the enterprising alcoholic or combat medicine)
CE pen can pulse wires like a multi tool
QM pen has integrated Accepted / Denied stamps

and since it would be only fair
Hop pen can check the access on a card (no editing)
captain pen can have a built in lighter (for burning all the documents before the IRS get in)

@justdie12
Copy link
Contributor Author

RD может сканировать аномалии (есл

If they're going to get unique abilities they need to be minor things which are already accomplished by other stuff what I would do for example CMO pen can be used for cauterizing injuries RD pen can scan anomalies (make it take longer than a normal scanner if possible) HOS pen can hold 5 units of a liquid (for the enterprising alcoholic or combat medicine) CE pen can pulse wires like a multi tool QM pen has integrated Accepted / Denied stamps

and since it would be only fair Hop pen can check the access on a card (no editing) captain pen can have a built in lighter (for burning all the documents before the IRS get in)

i do some of this functions.

@beck-thompson
Copy link
Contributor

I actually think the QMs ability is fine, it should just be a lower cap! I was thinking HOSes should be like low power flashlight or something.

@UBlueberry
Copy link
Contributor

If they're going to get unique abilities they need to be minor things which are already accomplished by other stuff what I would do for example CMO pen can be used for cauterizing injuries RD pen can scan anomalies (make it take longer than a normal scanner if possible) HOS pen can hold 5 units of a liquid (for the enterprising alcoholic or combat medicine) CE pen can pulse wires like a multi tool QM pen has integrated Accepted / Denied stamps

and since it would be only fair Hop pen can check the access on a card (no editing) captain pen can have a built in lighter (for burning all the documents before the IRS get in)

even this is too much IMO. my issue that is that the pens are too overpowered, it's that they shouldn't have power in the first place. they're pens.
what if every head's flash got a "special feature"? would it make sense if the RD pulls out a flash to scan an anomaly instead of using an anomaly scanner?
if you think that's a bad idea, then why should a pen do the same?
flashes are for self-defense. pens are for writing. let them stay that way, please

@justdie12 justdie12 marked this pull request as draft October 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.