Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CargoPallet component from the cargo pallet #33022

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove CargoPallet component from the cargo pallet #33022

wants to merge 3 commits into from

Conversation

Minemoder5000
Copy link
Contributor

About the PR

Removes the CargoPallet component from the cargo pallet

Why / Balance

Fixes #32977

Technical details

Removed a couple lines of yaml

Media

Requirements

Breaking changes

Changelog

Minemoder
🆑

  • fix: The cargo shuttle's cargo pallets can no longer sell or buy.

@github-actions github-actions bot added No C# For things that don't need code. Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. labels Oct 27, 2024
@Minemoder5000
Copy link
Contributor Author

uh oh, something got pushed that shouldnt've been pushed

@0x6273
Copy link
Contributor

0x6273 commented Oct 27, 2024

Probably needs a name change also to avoid confusion?

@UbaserB
Copy link
Member

UbaserB commented Oct 27, 2024

Probably needs a name change also to avoid confusion?

nah its fine, iirc the desc. got changed in another pr already a while ago

@Minemoder5000
Copy link
Contributor Author

Can confirm,
image

slarticodefast
slarticodefast approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@slarticodefast slarticodefast added the PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them. label Oct 28, 2024
@slarticodefast slarticodefast self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. No C# For things that don't need code. PR: Approved Indicates that a PR has been approved by a maintainer and it may be merged soon by them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cargo sale computer can sell using the Cargo shuttle cargo pallets
4 participants
@Minemoder5000 @0x6273 @UbaserB @slarticodefast