Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gas pumps only consume power when enabled #33021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Boolean-Buckeye
Copy link

@Boolean-Buckeye Boolean-Buckeye commented Oct 27, 2024

About the PR

Make pressure and volume gas pumps only consume power when enabled

Why / Balance

I was playing the game and wondered where my power consumption was when I was trying to optimize power in a small area. It took me a while to figure out that the gas pumps that were off were the culprits that were consuming power. I consider this as a bug, so I came here to try to change it, I think that the pumps should not consume power when disabled.

Technical details

  • toggle power of gas pumps when UI button to enable/disable is pressed to match the enabled value of the pump

  • toggle power of gas pumps to match the enabled status of the pump whenever there is a change to the power of the pump (most likely case other than UI toggle is anchoring the pump to the floor, if this isnt done then pump would consume power when off when first anchored or if meant to be off when the map is first loaded)

Requirements

Breaking changes

Changelog

🆑

  • tweak: Gas pumps no longer consume power when disabled.

* make pressure and volume gas pumps only consume power when enabled

* toggle power of gas pumps when UI button to enable/disable is pressed
  to match the enabled value of the pump

* toggle power of gas pumps to match the enabled status of the pump
  whenever there is a change to the power of the pump (most likely case
  other than UI toggle is anchoring)
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Oct 27, 2024
@pheenty
Copy link
Contributor

pheenty commented Oct 27, 2024

I wish it was the same with thrusters

@Boolean-Buckeye
Copy link
Author

Boolean-Buckeye commented Oct 27, 2024

I wish it was the same with thrusters

AFAIK it is the same already, I tend to hook a button to them to toggle them when not using it and saves a ton of power

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants