Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursed mask bug #33014

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

FireNameFN
Copy link

@FireNameFN FireNameFN commented Oct 26, 2024

About the PR

Fixed bug where you can equip cursed mask that makes you angry, die, get rid of cursed mask and get healed. With this bug after these actions you will be notarget for almost all NPCs. But with this fix behavior will be expectable.

Why / Balance

Bug fix.

Technical details

Save copy of faction list.

Requirements

Breaking changes

Changelog

No changelog.

@deltanedas
Copy link
Contributor

does HashSet not have Clone or something this seems like it would trip up anyone seeing it in the future not familiar with why its being used

@metalgearsloth metalgearsloth added the Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. label Oct 27, 2024
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged. labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants