Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predict dumping #32394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Predict dumping #32394

wants to merge 2 commits into from

Conversation

metalgearsloth
Copy link
Contributor

  • This got soaped really fucking hard.
  • Dumping is predicted, this required disposals to be predicte.d
  • Disposals required mailing (because it's tightly coupled), and a smidge of other content systems.
  • I also had to fix a compnetworkgenerator issue at the same time so it wouldn't mispredict.

Breaking namespace changes for a bunch of stuff that got predicted / needed to be in shared, mostly device network + configurator + disposals.

Requires space-wizards/RobustToolbox#5459 so it doesn't mispredict.

@metalgearsloth
Predict dumping
77877aa 
- This got soaped really fucking hard.
- Dumping is predicted, this required disposals to be predicte.d
- Disposals required mailing (because it's tightly coupled), and a smidge of other content systems.
- I also had to fix a compnetworkgenerator issue at the same time so it wouldn't mispredict.
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Merge Conflict This PR currently has conflicts that need to be addressed. labels Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@notquitehadouken
Copy link
Contributor

Me when fixing one issue creates a 1500 line PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jezithyr Jezithyr Awaiting requested review from Jezithyr Jezithyr is a code owner

@Partmedia Partmedia Awaiting requested review from Partmedia Partmedia is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@Chief-Engineer Chief-Engineer Awaiting requested review from Chief-Engineer Chief-Engineer is a code owner

Assignees
No one assigned
Labels
Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Merge Conflict This PR currently has conflicts that need to be addressed. Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalgearsloth @notquitehadouken