Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellable audio #5632

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JerryImMouse
Copy link
Contributor

Added cancellable event to cancel attempts of playing audio

Resolves #5611

@JerryImMouse
Copy link
Contributor Author

idk if I should raise this on client-side too, let me know if its needed

Comment on lines +278 to +283

/// <summary>
/// Raised directed at an entity, which is emitting the audio. Raised only when audio played at the entity itself, not the coordinates.
/// </summary>
[ByRefEvent]
public record struct PlayAudioAttemptEvent(bool Cancelled = false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clientside equivalents to PlayPvs should also be raising this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioSystem should raise a cancellable event to block audio from playing
2 participants