-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
two comments for testing collaboration #7
base: master
Are you sure you want to change the base?
Conversation
edited for clarity
Added Headers and Method sections.
Added comment
janus/message-transport.md
Outdated
|
||
### Headers | ||
Accept: message/vnd.janus | ||
Content-Type: message/vnd.janus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like vnd! vnd suggest that it is vender specific. like vnd.ms-excel from Microsoft. I think we should choose one even if it's not part of the mime-type spec. We can use it and I think we can get it into the spec fairly easily once we have adoption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. How about message/janus? You suggested application/sov-msg. Other options are application/indy-msg, application/janus-msg. The reason I suggested message\
is because it exists and seems more applicable than application. I suggest janus
because I think the peer-to-peer protocol could be independent of Sovrin or of Indy. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the top level type 'message'. Did not know it existed but it expresses what we want just fine. Not a lot of register sub-types for 'message', so it should be easy to get accepted into the standard. The only concern I would have is sometimes when a part of a spec is ill-used the real world implementation doesn't work well. I think we found this with TLS. The overwhelming majority are 'application', I wonder if there are implementations that assume normal top-level types (application, image, video, etc). I don't think this is too important.
I like not attaching to sovrin or indy. It is a good insight that I was not thinking of. We should be hoping that there are uses for this outside of sovrin or Indy.
more comments
Removed vnd
No description provided.