Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: add public n_hashes fn to signature #3470

Closed
wants to merge 2 commits into from
Closed

Conversation

bluegenes
Copy link
Contributor

We need to be able to get the number of hashes in a minhash for accurate manifest writing. This function allows us to get it directly from the signature.
ref sourmash-bio/sourmash_plugin_branchwater#574

@bluegenes
Copy link
Contributor Author

@ctb ready for review

@bluegenes bluegenes added the rust label Jan 6, 2025
@ctb
Copy link
Contributor

ctb commented Jan 6, 2025

Wouldn't we want these on Sketch (where size already exists)? What code are we trying to use these in? :)

I worry about the unimplemented bit, which connects to the issues discussed here: #3333

@bluegenes
Copy link
Contributor Author

ah - things I did not realize: since SigsTrait is public, all it's functions are public, and I can actually access size. We still have the frustration of finding the first minhash(), but it is manageable without this PR. thx for review!

@bluegenes bluegenes closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants