Feat/null space allocation #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammad-shahabadi
force-pushed
the
feat/null-space-allocation
branch
from
cbdf94c to
c4ecf87
Compare
benmurphyy
approved these changes
Dec 2, 2024
| this.dataSegmentByteStr = { value: "" }; | ||
| this.dataSegmentOffset = { value: 0 }; | ||
| // Initial value to reserve for the null space | ||
| this.dataSegmentByteStr = { value: '\\d0\\e0\\b0\\f0' }; |
There was a problem hiding this comment.
any reason for this particular value? Although it shouldn't matter anyway
There was a problem hiding this comment.
We wanted a specific value in hex for debugging purposes. We chose "DEBF" which stands for "Debugging Errors Before Failing".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
Reserve the address 0 in data segment for null value. It will be used in the object registry to identify foreign objects that are null.
ATTENTION:
This pull request should only be merged after #10 since that pull request fix a specific bug related to data segement which is relevant to this feature.
Tests:
All of them are passed.