Bulletproofing Event Redispatching #2
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat for whatever reason you have a broken jQuery/Prototype install basic events will still fire.
| }else if(window.Prototype){ | ||
| // if Prototype.js is available, fire the custom event | ||
| $(playerNode).fire(customEventType, data); | ||
| try { | ||
| $(playerNode).fire(customEventType, data); |
There was a problem hiding this comment.
it makes sense, I guess. Could you format/indent it accordingly, and we'll merge it in. thanks!
There was a problem hiding this comment.
Sure thing, I've changed the indentation to spaces, and removed some of the whitespace from the if/try/catch statements to match your formatting in 0326c6e.
|
@bruderstein can we get some movement here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some bulletproofing to the API event dispatching, in the event that for whatever reason you have a broken jQuery/Prototype install basic events will still fire.
We found that for whatever reason Prototype's .fire event was failing, which would cause basic events to fail silently. This added a tiny bit to the filesize, so I went ahead and made a minified version using yui compressor v2.4.2.