Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove langchain #279

Merged
merged 10 commits into from
Feb 1, 2025
Merged

remove langchain #279

merged 10 commits into from
Feb 1, 2025

Conversation

XuhuiZhou
Copy link
Member

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

β„Ή Additional Information

@XuhuiZhou XuhuiZhou requested a review from ProKil January 25, 2025 01:48
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 73.88060% with 35 lines in your changes missing coverage. Please review.

Project coverage is 75.82%. Comparing base (ea14fda) to head (0275024).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sotopia/generation_utils/output_parsers.py 70.37% 24 Missing ⚠️
sotopia/generation_utils/generate.py 80.00% 9 Missing ⚠️
sotopia/agents/llm_agent.py 0.00% 1 Missing ⚠️
sotopia/agents/redis_agent.py 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   75.34%   75.82%   +0.48%     
==========================================
  Files          64       63       -1     
  Lines        3727     3595     -132     
==========================================
- Hits         2808     2726      -82     
+ Misses        919      869      -50     
Files with missing lines Coverage Ξ”
sotopia/cli/benchmark/benchmark.py 86.72% <100.00%> (-0.25%) ⬇️
sotopia/envs/evaluators.py 90.34% <100.00%> (-0.07%) ⬇️
sotopia/generation_utils/__init__.py 100.00% <100.00%> (ΓΈ)
sotopia/server.py 44.63% <100.00%> (-0.32%) ⬇️
tests/generation_utils/test_generation.py 100.00% <100.00%> (ΓΈ)
sotopia/agents/llm_agent.py 44.66% <0.00%> (ΓΈ)
sotopia/agents/redis_agent.py 20.83% <0.00%> (-1.09%) ⬇️
sotopia/generation_utils/generate.py 65.54% <80.00%> (+2.63%) ⬆️
sotopia/generation_utils/output_parsers.py 70.37% <70.37%> (ΓΈ)

@XuhuiZhou XuhuiZhou changed the title supported o1 remove langchain Jan 25, 2025
@ProKil
Copy link
Member

ProKil commented Feb 1, 2025

Can we keep uv.lock for development environment consistency?

@XuhuiZhou
Copy link
Member Author

Can we keep uv.lock for development environment consistency?

I am not sure if I follow, what do you mean specifically?

@ProKil
Copy link
Member

ProKil commented Feb 1, 2025

NVM, I thought uv.lock is removed.

@XuhuiZhou XuhuiZhou merged commit fd1b4d9 into main Feb 1, 2025
9 checks passed
@ProKil ProKil deleted the feature/add_o1 branch February 1, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants