Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chess] Fix _possible_piece_positions when castling #983

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[Chess] Fix _possible_piece_positions when castling #983

merged 2 commits into from
Jul 21, 2023

Conversation

HongruiTang
Copy link
Contributor

kingside and queenside castling

@HongruiTang HongruiTang marked this pull request as draft July 19, 2023 14:44
@sotetsuk
Copy link
Owner

#982

@sotetsuk
Copy link
Owner

Thank you for sending PR! 🤟
Could you kindly apply formatter w/ make install-fmt and make format? (or I guess black pgx is enough)

@sotetsuk
Copy link
Owner

sotetsuk commented Jul 20, 2023 •
edited
Loading

As your description in #982 sounds reasonable. I'll merge this PR immediately when

Feel free to let me know. I'm happy to help you to merge this PR! 👍

@HongruiTang
Copy link
Contributor Author

Hi, I added a new test under the buggy_test part and applied the formatter

@sotetsuk
Copy link
Owner

Thanks a lot! I'll review and merge in a few days! 👍 🙏

@sotetsuk sotetsuk marked this pull request as ready for review July 21, 2023 02:52
@sotetsuk
Copy link
Owner

LGTM! 👍

@sotetsuk sotetsuk changed the title fix: fix Rook position updating in possible_piece_positions array in … [Chess] Fix _possible_piece_positions when castling Jul 21, 2023
@sotetsuk sotetsuk merged commit ebd2342 into sotetsuk:main Jul 21, 2023
4 checks passed
@sotetsuk sotetsuk mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HongruiTang @sotetsuk