New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOT-153: Add parser to parse simple equation like "x^2 + 2*x + 2" into circuits compatible for plonk #12

Closed

ktokto313 wants to merge 21 commits into main from parser

Contributor

ktokto313 commented May 4, 2024

No description provided.

ktokto313 requested a review from 0x5ea000000

May 4, 2024 09:37

github-advanced-security bot found potential problems

View reviewed changes

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

ktokto313 changed the title ~~Add parser to parse simple equation like "x^2 + 2*x + 2" into circuits compatible for plonk~~ SOT-153: Add parser to parse simple equation like "x^2 + 2*x + 2" into circuits compatible for plonk

linear bot commented May 4, 2024

SOT-153 Plonk circuit parser

github-advanced-security bot found potential problems

View reviewed changes

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

zk-steve reviewed

View reviewed changes

plonk/main.rs Outdated Show resolved Hide resolved

zk-steve reviewed

View reviewed changes

plonk/src/parser.rs Show resolved Hide resolved

zk-steve reviewed

View reviewed changes

plonk/src/parser.rs Outdated Show resolved Hide resolved

zk-steve reviewed

View reviewed changes

plonk/src/parser.rs Outdated Show resolved Hide resolved

zk-steve reviewed

View reviewed changes

plonk/src/parser.rs Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems

View reviewed changes

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs Fixed Show fixed Hide fixed

plonk/src/parser.rs

+                  fn prepare_gen_circuit(
+                      &self,
+                      string: &str,
+                  ) -> (Vec<Gate>, HashMap<String, Vec<(usize, usize)>>) {

Check warning

Code scanning / clippy

very complex type used. Consider factoring parts into type definitions Warning

very complex type used. Consider factoring parts into type definitions

ktokto313 requested a review from zk-steve

May 7, 2024 04:13

zk-steve requested review from VanhGer, hduoc2003, thuan2172001 and bjergsen243

May 15, 2024 03:27

zk-steve and others added 13 commits

May 17, 2024 08:42


          add expectation

ef5ae0a


          Testing

c1289ed


          Commit

b950bc9


          Update parser.rs

4d49f9a


          Update parser.rs

09e87d2


          add expectation

c7e5512


          Update parser.rs

8155c39


          Update parser.rs

e5411cf


          parser

ef2e9f8

fix

659d399


          Update parser.rs

23ca835


          Update parser.rs

1061af6


          Update parser.rs

8aaaecf

zk-steve and others added 6 commits

May 17, 2024 08:42


          temp

ab61251


          update


          Optimize code

83de621


          Update parser.rs

dc00279


          Change position map shuffling algorithm

8887f6b


          Update parser.rs

f5f9f10

zk-steve force-pushed the parser branch from e571027 to f5f9f10 Compare

May 17, 2024 08:42


          Fix parser: add constant gate support

9a90bef

ktokto313 force-pushed the parser branch from f79097b to 9a90bef Compare

May 31, 2024 10:40


          Fix parser: add integer larger than 9 power support

ee2740a

ktokto313 force-pushed the parser branch from c95b474 to ee2740a Compare

June 1, 2024 03:46

ktokto313 mentioned this pull request

SOT 164: Add Parser #15

Merged

zk-steve closed this

zk-steve deleted the parser branch

July 10, 2024 03:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

0x5ea000000 Awaiting requested review from 0x5ea000000

zk-steve Awaiting requested review from zk-steve

VanhGer Awaiting requested review from VanhGer

hduoc2003 Awaiting requested review from hduoc2003

thuan2172001 Awaiting requested review from thuan2172001

bjergsen243 Awaiting requested review from bjergsen243

Labels

None yet