build: pin urllib3<2.3 to accommodate our old fork of vcrpy #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2025
Exirel
approved these changes
Jan 24, 2025
We can unpin this when py3.9 support drops in October 2025. Original hope was to get a PR merged upstream in vcrpy that fixes the urllib version issues with Python < 3.10, but that hasn't gone anywhere.
|
Sorry, have to request re-review. 😅 I needed to also fix stricter checks from |
Exirel
approved these changes
Jan 24, 2025
dgw
added a commit
that referenced
this pull request
Jan 26, 2025
build: pin urllib3<2.3 to accommodate our old fork of vcrpy Also includes slight `typing.cast()` changes to accommodate new version of flake8-type-checking.
This was referenced Jan 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had the itch to work on a feature for 8.1, but noticed that unrelated tests were failing when I started validating my changes…
urllib32.3.0, released 22 December 2024, broke compatibility withvcrpy5.x by using aresponse.version_stringattribute that's missing from the mocked-up response objects. (The diff looks pretty innocuous, but every change has the potential to break someone's workflow, right?.)Upstream has fixed this for vcrpy 7.x, but we're on an old fork of vcrpy 5.x due to incompatibilities with mixed
urllibversions across older versions of Python (see #2456).I'll add a note to #2456 with an update on the current state of this. We can remove the pin again when py3.9 support drops in October 2025. Original hope was to get a PR merged upstream in vcrpy that fixes the urllib version issues with Python < 3.10, but that hasn't gone anywhere.
Checklist
make qa(runsmake lintandmake test)Notes
Milestoned for 8.0.2 because it'll need backporting to the maintenance branch (otherwise CI there will be broken).