config: space before zone in default_time_format
's default
#2531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dates like
2023-10-26 - 23:45CDT
look a bit weird, and should be presented as2023-10-26 - 23:45 CDT
. (The default timezone is still UTC, don't worry.)Checklist
make qa
(runsmake lint
andmake test
)make test
, from thevcrpy
problem that build, test: upgrade to vcrpy>=5 & refresh broken cassettes #2519 is meant to fix. CI seems to bypass that, so I should be fine. *knocks on wood*Notes
While making this, I noticed that Sphinx does not output any of the attribute values. Because of that, we have the same default value defined in three different places. The header line for each attribute ideally would look like a module-level constant, e.g.
name_of_config_attribute = ListAttribute('name_of_config_attribute', default=['list', 'of', 'defaults'])
(andListAttribute
there would link to the type, of course). It'd save us having to duplicate default values in docstrings, at least.This patch can't do anything about it, and I couldn't figure out in half an hour of research how to change the docs so Sphinx would do it—but now I'm annoyed, so I wanted to pass that along to everyone else. 🤪