Package search support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Never planned to support this feature, so a refactor is probably due. However, this slightly-kludgy approach doesn't seem to break anything. Also (re)discovered a bug in Sopel while writing this patch, which is nice since it'll push us toward making plugin loading more robust.
Search implementation uses enums, which were added in Python 3.4 -- and more specifically, a new Python 3.6 feature, enum.auto.
|
Still need a refactor, and not willing to restrict this plugin's Python version compatibility more than Sopel itself. If implementing search needs stdlib features from Python 3.6+, this can stay on the back burner until it's time for a Sopel 8+ version (since Sopel 8 is going to support only py3.8+). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never planned to support this feature, so a refactor is probably due. However, this slightly-kludgy approach doesn't seem to break anything.
Also (re)discovered a bug in Sopel while writing this patch, which is nice since it'll push us toward making plugin loading more robust.