[orchagent]: VXLAN: Fix oper_status and tunnel encapsulation TTL #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
force-pushed
the
vxlan-fixes
branch
2 times, most recently
from
603980f to
75c4f03
Compare
This was referenced Nov 20, 2024
|
@VladimirKuk any idea if those test failures are actually a symptom of the patch itself? Or is it just common for things to fail in the tests from time to time? |
|
Tests do fail from time to time. |
|
@prsunny please review |
|
Thank you for pushing this forward! |
|
@prsunny ping |
bradh352
force-pushed
the
vxlan-fixes
branch
3 times, most recently
from
1ad6c1e to
89b365a
Compare
|
@VladimirKuk I ended up having to sprinkle your suggestion in 2 places to get it fully working. |
VladimirKuk
approved these changes
Dec 5, 2024
prsunny
reviewed
Dec 5, 2024
|
@prsunny how would you like to proceed on this? I think this is a critical issue since community SONiC doesn't support ARP/ND suppression so things just don't work at all without this. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny looks like the internal msconflict is resolved now since pvst was merged to main. Please review and hopefully merge. Thanks! |
bradh352
force-pushed
the
vxlan-fixes
branch
from
a000ef4 to
6a9f067
Compare
|
/azp run |
srj102
reviewed
Jan 22, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
srj102
approved these changes
Jan 22, 2025
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 23, 2025
…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)
This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)
…nce TTL is set to non-zero
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
looks like builds were hanging yesterday ... I rebased my commits on current master to force a rebuild ... hopefully its fixed today. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
just forced a rebuild, tests failed in srv6 tests ... shouldn't be related in any way to my changes |
add to sip and dip tests for completeness
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
only failures in the log are srv6 related, just like the minimal PR in #3482 also failing due to SRV6 tests failing |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 29, 2025
…onic-net#3383) This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ``` The VTEP is really up. Original PR for that is sonic-net#2080. Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging. The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is sonic-net#3216, however it appears it has its origins in sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3 Fixes sonic-net#3216 Fixes sonic-net#2080 Fixes sonic-net/sonic-buildimage#10050 Fixes sonic-net/sonic-buildimage#10004 Signed-off-by: Brad House (@bradh352)
|
@prsunny looks like tests are passing now that the SRv6 fixes got merged yesterday. Can this be merged now? |
bradh352
added a commit
to bradh352/sonic-swss
that referenced
this pull request
Jan 30, 2025
…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```
|
Can we get this backported to 202411? Thanks! |
github-actions bot
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Feb 8, 2025
…ic-net#3383) * VXLAN: Fix oper_status and tunnel encapsulation TTL This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk. The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible: ``` +------------+------------+-------------------+--------------+ | SIP | DIP | Creation Source | OperStatus | +============+============+===================+==============+ | 172.16.0.1 | 172.16.0.2 | EVPN | oper_down | +------------+------------+-------------------+--------------+ Total count : 1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This fixes 2 issues across a range of open tickets building upon patches created by others with modifications as requested by @VladimirKuk.
The first issue this resolves is the status shown for remote vteps which in the fact that it is wrong makes debugging nearly impossible:
The remote VTEP is really up.
Original PR for that is #2080.
Also fixes sonic-net/sonic-buildimage#10004 or at least the error message which hurts debugging.
The next issue is in reachabiity across VXLANs. This fixes IP/MAC learning via ARP. The original PR for that is #3216, however it appears it has its origins in
sonic-net/sonic-buildimage#10050 which goes into greater detail about the issue itself. Also there is talk about it here kamelnetworks/sonic#9 as well as another similar patch here: kamelnetworks@02ee3e3
Why I did it
Fixes #3216
Fixes #2080
Fixes sonic-net/sonic-buildimage#10050
Fixes sonic-net/sonic-buildimage#10004
How I verified it
Pulled into my private sonic-swss fork:
https://github.com/bradh352/sonic-swss/commits/bradh352/master
Which is pulled in by my private sonic-buildimage fork:
https://github.com/bradh352/sonic-buildimage/tree/bradh352/master
Which is then automatically built when changes are made. Then the uploaded asset of sonic-broadcom.bin is installed onto Dell S5248F switches and tested.
Update: also now tested by me on Mellanox/NVidia SN2201
Details if related
Signed-off-by: Brad House (@bradh352)
This should also be backported to 202411, 202405