Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fpmsyncd] support pipeline to flush with a timer #3241

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[fpmsyncd] support pipeline to flush with a timer #3241

wants to merge 1 commit into from

Conversation

a114j0y
Copy link

@a114j0y a114j0y commented Jul 22, 2024

What I did

  • change the pipeline size for RouteSync
  • modify the fpmsyncd flush behavior so that it could delay the flush with an expiring timer
    • the timer is simulated by setting the timeout for select function

Why I did it

  • to batch the data that fpmsyncd flush to APP_DB

How I verified it
measure the performance with PerformanceTimer GitHub issue/pull request detail

@a114j0y a114j0y requested a review from prsunny as a code owner July 22, 2024 21:48
@a114j0y a114j0y mentioned this pull request Jul 22, 2024
Open
siqbal1986
siqbal1986 reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@siqbal1986 siqbal1986 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test covering this change. how can we see if this is working as intended.
Also the build is failing. Can you please look into it.

@a114j0y
Copy link
Author

a114j0y commented Oct 7, 2024 •
edited
Loading

Is there a test covering this change. how can we see if this is working as intended. Also the build is failing. Can you please look into it.

Its compilation needs this pr to be merged

@a114j0y a114j0y force-pushed the flushwithtimer branch 2 times, most recently from 45568ef to 5af28d2 Compare October 22, 2024 21:56
@a114j0y a114j0y marked this pull request as draft October 30, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@siqbal1986 siqbal1986 Awaiting requested review from siqbal1986

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a114j0y @siqbal1986