Create is_transceiver_vdm_supported API for CMIS transceivers #527
Conversation
Signed-off-by: Mihir Patel <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -55,6 +55,10 @@ def is_coherent_module(self): | |||
| api = self.get_xcvr_api() | |||
| return api.is_coherent_module() if api is not None else None | |||
|
|
|||
| def is_transceiver_vdm_supported(self): | |||
| api = self.get_xcvr_api() | |||
| return api.is_transceiver_vdm_supported() if api is not None else None | |||
There was a problem hiding this comment.
return False on falure? @mihirpat1
There was a problem hiding this comment.
@prgeor I am currently returning None because the caller (xcvrd in this case) treats None as False and will not perform VDM-related operations. This approach ensures that the current behavior remains unchanged. Additionally, if in the future the caller needs to differentiate between False (explicitly not supported) and None (indeterminate or error state), the current implementation will allow for this distinction without requiring changes to the existing implementation.
|
@mihirpat1 we need in 202412 branch |
|
@kperumalbfn Can you please help to cherry-pick this to 202411 branch? MSFT ADO - 30657693 |
|
Cherry-pick PR to 202411: #537 |
Description
is_transceiver_vdm_supported API needs to be created so that xcvrd can directly skip freezing/unfreezing of VDM stats (done to read VDM and PM data from the transceiver) for transceivers which do not support VDM feature.
Motivation and Context
XCVRD will call
is_transceiver_vdm_supportedAPI before performing freeze of VDM stats.How Has This Been Tested?
Following types of modules were tested with this changeset
Additional Information (Optional)
MSFT ADO - 30657693