visibility declarations; make all targets public. Set role. Adding ad…

…ditional BERT tests.
sonic-net · Nov 1, 2024 · 2175df5 · 2175df5
1 parent a7754ae
commit 2175df5
Show file tree

Hide file tree

Showing 5 changed files with 347 additions and 5 deletions.
diff --git a/tests/forwarding/BUILD.bazel b/tests/forwarding/BUILD.bazel
@@ -82,7 +82,6 @@ cc_library(
     testonly = True,
     srcs = ["smoke_test.cc"],
     hdrs = ["smoke_test.h"],
-    visibility = ["//visibility:public"],
     deps = [
         ":p4_blackbox_fixture",
         ":test_data",

diff --git a/tests/forwarding/p4_blackbox_fixture.h b/tests/forwarding/p4_blackbox_fixture.h
@@ -68,7 +68,7 @@ class P4BlackboxFixture : public thinkit::MirrorTestbedFixture {
   }
 
   void TearDown() override {
-    if (SutP4RuntimeSession() != nullptr) {
+    if (SutP4RuntimeSession() != nullptr && clear_table_entries_on_teardown_) {
       // Clear all table entries to leave the switch in a clean state.
       EXPECT_OK(pdpi::ClearTableEntries(SutP4RuntimeSession()));
     }
@@ -82,9 +82,16 @@ class P4BlackboxFixture : public thinkit::MirrorTestbedFixture {
 
   const pdpi::IrP4Info& IrP4Info() const { return ir_p4info_; }
 
+ protected:
+  void DisableClearingTableEntriesOnTearDown() {
+    clear_table_entries_on_teardown_ = false;
+  }
+
  private:
+  bool clear_table_entries_on_teardown_ = true;
   std::unique_ptr<pdpi::P4RuntimeSession> sut_p4rt_session_;
-  pdpi::IrP4Info ir_p4info_ = sai::GetIrP4Info(sai::Instantiation::kMiddleblock);
+  pdpi::IrP4Info ir_p4info_ = 
+      sai::GetIrP4Info(sai::Instantiation::kMiddleblock);
 };
 
 }  // namespace gpins

diff --git a/tests/forwarding/smoke_test.cc b/tests/forwarding/smoke_test.cc
@@ -129,8 +129,9 @@ TEST_P(SmokeTestFixture, InsertAndReadTableEntries) {
 
   p4::v1::ReadRequest read_request;
   read_request.add_entities()->mutable_table_entry();
-  ASSERT_OK_AND_ASSIGN(p4::v1::ReadResponse read_response,
-                       pdpi::SetMetadataAndSendPiReadRequest(session, read_request));
+  ASSERT_OK_AND_ASSIGN(
+      p4::v1::ReadResponse read_response,
+      pdpi::SetMetadataAndSendPiReadRequest(session, read_request));
 
   for (const auto& entity : read_response.entities()) {
     ASSERT_OK(test_environment.AppendToTestArtifact(

diff --git a/tests/gnoi/BUILD.bazel b/tests/gnoi/BUILD.bazel
@@ -34,6 +34,8 @@ cc_library(
         "//thinkit:mirror_testbed_fixture",
         "@com_github_gnoi//diag:diag_cc_proto",
         "@com_github_google_glog//:glog",
+        "@com_google_absl//absl/container:flat_hash_set",
+        "@com_google_absl//absl/flags:flag",
         "@com_github_grpc_grpc//:grpc++",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/time",